Add time_window parameter for temporal neighbor sampling#10652
Open
RishiBanerjee wants to merge 2 commits intopyg-team:masterfrom
Open
Add time_window parameter for temporal neighbor sampling#10652RishiBanerjee wants to merge 2 commits intopyg-team:masterfrom
time_window parameter for temporal neighbor sampling#10652RishiBanerjee wants to merge 2 commits intopyg-team:masterfrom
Conversation
Introduces a `time_window` parameter to `NeighborLoader` and `NeighborSampler` that restricts neighbor sampling to a time window `[input_time - time_window, input_time]`. Implemented as a Python-side sentinel-masking pre-filter so it works with the existing pyg-lib and torch-sparse kernels without modification. Adds `WITH_TIME_WINDOW_NEIGHBOR_SAMPLE` capability flag in `torch_geometric/typing.py` for future native kernel support.
RishiBanerjee
requested review from
akihironitta,
mananshah99,
rusty1s and
wsad1
as code owners
The batch-level approximation for time_window filtering becomes inaccurate when seed times vary more than time_window within a batch. Add a UserWarning in both homogeneous and heterogeneous paths, and document the limitation in the NeighborSampler docstring. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a
time_windowparameter toNeighborLoaderandNeighborSamplerthat restricts neighbor sampling to a time window[input_time - time_window, input_time]. Implemented as a Python-side sentinel-masking pre-filter so it works with the existing pyg-lib and torch-sparse kernels without modification. AddsWITH_TIME_WINDOW_NEIGHBOR_SAMPLEcapability flag intorch_geometric/typing.pyfor future native kernel support.This is made to be a solution in pytorch-geometric to #10593