Open
Conversation
…ic into models/nodeformer
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10409 +/- ##
==========================================
- Coverage 86.11% 84.16% -1.96%
==========================================
Files 496 511 +15
Lines 33655 36305 +2650
==========================================
+ Hits 28981 30555 +1574
- Misses 4674 5750 +1076 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
@xnuohz plz get CI passing |
puririshi98
approved these changes
Sep 9, 2025
Contributor
puririshi98
left a comment
There was a problem hiding this comment.
LGTM just get CI green
Contributor
|
@rusty1s @akihironitta @wsad1 ready for final review/merge |
puririshi98
requested changes
Oct 27, 2025
Contributor
puririshi98
left a comment
There was a problem hiding this comment.
@xnuohz can you explain where we are ensuring attention is not being done across the full minibatch? we should be utilizing the batch tensor, no? (remember what we had to change for sgformer)
…ic into models/nodeformer
auto-merge was automatically disabled
November 1, 2025 17:12
Head branch was pushed to by a user without write access
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Usage
Highlight
Result