Merged
Conversation
Collaborator
|
I think we should also unpin ncempy |
Member
Author
|
Yes, that can be unpinned. With this change, pip will install numpy 2 so everything in the requirements is compatible |
smribet
approved these changes
Mar 14, 2025
Collaborator
smribet
left a comment
smribet
left a comment
There was a problem hiding this comment.
Ok! It looks good to me, thanks! I'll approve, but wait until next week to merge in case anyone else wants to weigh in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the use of aliases deprecated by numpy 2 by running
ruff check py4DSTEM --select NPY201 --fixand updatesetup.pyto no longer restrictnumpy < 2.0.Based on the migration guide I don't anticipate any further problems within py4DSTEM from using numpy 2.
Addresses #710.