Skip to content

Fix argument order on compose up#1037

Open
deligatedgeek wants to merge 3 commits intopuppetlabs:mainfrom
sohonet:fix_compose
Open

Fix argument order on compose up#1037
deligatedgeek wants to merge 3 commits intopuppetlabs:mainfrom
sohonet:fix_compose

Conversation

@deligatedgeek
Copy link
Copy Markdown

Summary

Correct the order of arguments in Docker compose command by moving the up_args to after the up command

Additional Context

Add any additional context about the problem here.

  • Root cause and the steps to reproduce. (If applicable)
  • Thought process behind the implementation.

Related Issues (if any)

Mention any related issues or pull requests.
#1036

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

@deligatedgeek deligatedgeek requested a review from a team as a code owner December 1, 2025 12:53
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Dec 1, 2025

CLA assistant check
All committers have signed the CLA.

Comment thread lib/puppet/provider/docker_compose/ruby.rb Outdated
@deligatedgeek deligatedgeek requested a review from smortex March 2, 2026 11:19
@deligatedgeek
Copy link
Copy Markdown
Author

@smortex how do we take this forward?

@deligatedgeek
Copy link
Copy Markdown
Author

I'm now using the requested change in production and it works.

@deligatedgeek
Copy link
Copy Markdown
Author

Hi @jst-cyr, can this be merged?

@jst-cyr
Copy link
Copy Markdown
Member

jst-cyr commented Mar 13, 2026

w using the requested change in production and it
Hi @jst-cyr, can this be merged?

I don't have any merge access, but I'll ping the team to see if this is one of the ones on their plates for review. Seems like a straightforward fix, though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants