feat: show photos of shared album in timeline#1371
Open
jovanbulck wants to merge 1 commit intopulsejet:masterfrom
Open
feat: show photos of shared album in timeline#1371jovanbulck wants to merge 1 commit intopulsejet:masterfrom
jovanbulck wants to merge 1 commit intopulsejet:masterfrom
Conversation
Fixes pulsejet#503, also possibly closes pulsejet#724 and closes pulsejet#947 Signed-off-by: Jo Van Bulck <jo.vanbulck@cs.kuleuven.be>
|
Thanks a lot for the awesome job ! Is there any chance to implement this in the near future ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #503, also possibly closes #724 and closes #947
This modifies the main DB query and adds a UI switch to optionally show photos of shared albums in the timeline.
Tested on MySQL and PostgreSQL.
Note: as the UI needs to be properly aware this is a read-only shared album photo or a photo from a (read-write) timeline directory, I needed to convert the subquery SELECT to a JOIN statement. Not sure if/how this impacts performance and if there is an easy way to measure performance impact, eg using a benchmark query (?)