fix(azure): normalize MySQL configuration values to uppercase#10398
Open
tejas0077 wants to merge 2 commits intoprowler-cloud:masterfrom
Open
fix(azure): normalize MySQL configuration values to uppercase#10398tejas0077 wants to merge 2 commits intoprowler-cloud:masterfrom
tejas0077 wants to merge 2 commits intoprowler-cloud:masterfrom
Conversation
Configuration values from Azure API can be mixed case (e.g. 'ON', 'on'). Normalizing to uppercase ensures consistent comparison in security checks.
github-actions
bot
added
provider/azure
Contributor
|
✅ Conflict Markers Resolved All conflict markers have been successfully resolved in this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Azure MySQL Flexible Server configuration values returned from the API
can be mixed case (e.g. "ON", "on", "On"). This causes security checks
to return incorrect results when comparing configuration values against
expected strings like "ON" or "OFF".
Added
.upper()normalization to configuration.value in mysql_service.py.None values are handled safely with a conditional check.
Before:
value=configuration.value,
After:
value=configuration.value.upper() if configuration.value else configuration.value,
No new dependencies required.
Are there new checks included? No
Review the one-line change in:
prowler/providers/azure/services/mysql/mysql_service.py
Run existing tests to verify:
python -m pytest tests/providers/azure/services/mysql/ -v
All 26 existing tests pass with the fix applied.