Make VM name comparison case-insensitive in azure vm_backup_enabled check#10373
Open
MalfuncEddie wants to merge 1 commit intoprowler-cloud:masterfrom
Open
Make VM name comparison case-insensitive in azure vm_backup_enabled check#10373MalfuncEddie wants to merge 1 commit intoprowler-cloud:masterfrom
MalfuncEddie wants to merge 1 commit intoprowler-cloud:masterfrom
Conversation
Contributor
|
✅ Conflict Markers Resolved All conflict markers have been successfully resolved in this pull request. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #10373 +/- ##
===========================================
+ Coverage 56.85% 86.12% +29.27%
===========================================
Files 87 223 +136
Lines 2846 5743 +2897
===========================================
+ Hits 1618 4946 +3328
+ Misses 1228 797 -431
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
FIX #10372
Description
This makes the vm comparison case insensitive
Steps to review
Please add a detailed description of how to review this PR.
Checklist
Community Checklist
SDK/CLI
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.