Draft
Conversation
Member
|
Task linked: CU-85zrnb6u1 PW - 631 ⁃ XML Handling |
Contributor
Author
|
@zubri fijate que te deje unos comments para confirmar sobre |
Contributor
Author
|
**Por lo que vi, a las clases Mx de dominio, deberíamos agregarle un metodo extra. Ejemplifico con MxPacs00800108: Existente:** Nuevo: |
zubri
reviewed
Feb 22, 2023
| //IS THIS OK OR WE SHOULD LEAVE AS UTF-8????? | ||
| if (usableConf.includeXMLDeclaration) { | ||
| xml.append("<?xml version=\"1.0\" encoding=\"UTF-8\" ?>\n"); | ||
| Charset charsetToUse =conf.charset != null? conf.charset:Charset.defaultCharset(); |
Member
There was a problem hiding this comment.
Esta ok esto... y estaría bueno probar generar un XML pasando un encoding diferente en Java y ver que genera.
Este cambio debiera romper unos cuantos test en tu maquina que creo que al ser Windows como default charset tiene algo distinto.
iso20022-core/src/main/java/com/prowidesoftware/swift/model/mx/MxParseUtils.java
Outdated
Show resolved
Hide resolved
iso20022-core/src/main/java/com/prowidesoftware/swift/model/mx/MxRead.java
Outdated
Show resolved
Hide resolved
iso20022-core/src/main/java/com/prowidesoftware/swift/model/mx/MxReadConfiguration.java
Outdated
Show resolved
Hide resolved
iso20022-core/src/main/java/com/prowidesoftware/swift/model/mx/MxReadParams.java
Outdated
Show resolved
Hide resolved
iso20022-core/src/main/java/com/prowidesoftware/swift/model/mx/MxWriteConfiguration.java
Outdated
Show resolved
Hide resolved
iso20022-core/src/main/java/com/prowidesoftware/swift/model/mx/MxWriteParams.java
Outdated
Show resolved
Hide resolved
zubri
reviewed
Feb 22, 2023
iso20022-core/src/main/java/com/prowidesoftware/swift/model/mx/MxRead.java
Outdated
Show resolved
Hide resolved
ptorres-prowide
force-pushed
the
CU-85zrnb6u1_PW---631--XML-Handling
branch
from
24dfcb1 to
eb43849
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.