fix(config): also error when env var in config is prefixed or suffixed#1500
Open
jonaskuske wants to merge 7 commits intoprometheus:mainfrom
Open
fix(config): also error when env var in config is prefixed or suffixed#1500jonaskuske wants to merge 7 commits intoprometheus:mainfrom
jonaskuske wants to merge 7 commits intoprometheus:mainfrom
Conversation
0dccf1a to
8109533
Compare
Signed-off-by: Jonas Kuske <[email protected]>
8109533 to
978af4a
Compare
Signed-off-by: Jonas Kuske <[email protected]>
Member
|
@jonaskuske do you mind fixing the findings of the linter and gofmt in order to get this merged? |
Signed-off-by: Jonas Kuske <[email protected]>
005971b to
a82e1ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues:
snmp_exporterbehaves: if an env var is missing while--config.expand-environment-variables, it errors while loading the config.I've updated the
READMEto reflect that.snmp_exporterwould neither error nor leave the string as-is. Instead,os.Expandwould silently replace the env vars found within the string with"".I've updated the implementation to also error when the (missing) env var is found within a larger string. A common failure scenario is having a password like
abcd$geh==1in the config: with--config.expand-environment-variables, this password would silently be changed toabcd==1(stripping the env var), so authentication against targets would fail despite having correct auths in the config.Now,
snmp_exportererrors and complains about the missing variablegeh.