config: allow setting default auth via YAML using default: true#1454
Open
nehro-em wants to merge 3 commits intoprometheus:mainfrom
Open
config: allow setting default auth via YAML using default: true#1454nehro-em wants to merge 3 commits intoprometheus:mainfrom
default: true#1454nehro-em wants to merge 3 commits intoprometheus:mainfrom
Conversation
Adds support for marking an SNMP auth block as the default by specifying `default: true` in the YAML configuration. When present, the marked auth is assigned to `DefaultAuth` and used wherever a default is needed. If multiple auths are marked as default, an error is returned. This makes the default behavior configurable without code changes.
Member
|
Hello @nehro-em , in order to get this PR merged you'd need to sign the commit - once thats done i'm happy to approve the changes and merge it . Thx for your contribution! |
Author
|
Merge to branch main |
Member
nehro-em
commented
Jul 31, 2025
Author
nehro-em
left a comment
nehro-em
left a comment
There was a problem hiding this comment.
Signed-off-by: Nehro E.M [email protected]
Member
|
This needs a DCO sign-off. You can use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for marking an SNMP auth block as the default by specifying
default: truein the YAML configuration. When present, the marked auth is assigned toDefaultAuthand used wherever a default is needed. If multiple auths are marked as default, an error is returned.This makes the default behavior configurable without code changes.