Skip to content

Print memory usage less aggressively #1587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gianlucam76 merged 1 commit into from
Jan 15, 2026
Merged

Print memory usage less aggressively #1587

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 22 additions & 12 deletions cmd/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ func main() {
ctrl.GetConfigOrDie())

debug.SetMemoryLimit(gibibytes_per_bytes)
go printMemUsage(ctrl.Log.WithName("memory-usage"))
go printMemUsage(ctx, ctrl.Log.WithName("memory-usage"))
controllers.NewLicenseManager()

if shardKey == "" && !disableTelemetry {
Expand Down Expand Up @@ -679,18 +679,28 @@ func startControllersAndWatchers(ctx context.Context, mgr manager.Manager) {
}

// printMemUsage memory stats. Call GC
func printMemUsage(logger logr.Logger) {
func printMemUsage(ctx context.Context, logger logr.Logger) {
const five = 5
ticker := time.NewTicker(five * time.Minute)
defer ticker.Stop()

for {
time.Sleep(time.Minute)
var m runtime.MemStats
runtime.ReadMemStats(&m)
// For info on each, see: /pkg/runtime/#MemStats
l := logger.WithValues("Alloc (MiB)", bToMb(m.Alloc)).
WithValues("TotalAlloc (MiB)", bToMb(m.TotalAlloc)).
WithValues("Sys (MiB)", bToMb(m.Sys)).
WithValues("NumGC", m.NumGC)
l.V(logs.LogInfo).Info("memory stats")
runtime.GC()
select {
case <-ctx.Done():
logger.Info("stopping memory usage printer")
return
case <-ticker.C:
time.Sleep(time.Minute)
var m runtime.MemStats
runtime.ReadMemStats(&m)
// For info on each, see: /pkg/runtime/#MemStats
l := logger.WithValues("Alloc (MiB)", bToMb(m.Alloc)).
WithValues("TotalAlloc (MiB)", bToMb(m.TotalAlloc)).
WithValues("Sys (MiB)", bToMb(m.Sys)).
WithValues("NumGC", m.NumGC)
l.V(1).Info("memory stats")
runtime.GC()
}
}
}

Expand Down