Conversation
Speed up builds and improve caching by moving the COPY commands to after the aws-iam-authenticator download. Our code will change more often than we update the aws-iam-authenticator pin, and Dockerfile best practice is to put more frequently changed layers later.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes Docker build caching by reordering layers in the Dockerfile. The COPY commands for application artifacts are moved to execute after the aws-iam-authenticator download, which changes less frequently than the application code itself. This follows Docker best practices of placing more frequently changing layers later in the Dockerfile to maximize cache hit rates and speed up builds.
Changes:
- Relocated COPY commands for
/resultsand/benchmarkfrom before to after the aws-iam-authenticator installation
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Speed up builds and improve caching by moving the COPY commands to after the aws-iam-authenticator download.
Our code will change more often than we update the aws-iam-authenticator pin, and Dockerfile best practice is to put more frequently changed layers later.