Skip to content

fix(custom-command-menu): add menu icon settings to dconf distro database#274

Merged
castrojo merged 2 commits intoprojectbluefin:mainfrom
dylanmtaylor:fix/custom-command-menu-icon
Apr 14, 2026
Merged

fix(custom-command-menu): add menu icon settings to dconf distro database#274
castrojo merged 2 commits intoprojectbluefin:mainfrom
dylanmtaylor:fix/custom-command-menu-icon

Conversation

@dylanmtaylor
Copy link
Copy Markdown
Contributor

@dylanmtaylor dylanmtaylor commented Apr 14, 2026

The custom-command-menu extension reads settings from its own bundled schema dir via getSettings(), so the gschema overrides in zz0-bluefin-modifications.gschema.override have no effect. Adds the menu display settings (icon, location, arrow) to the dconf distro database where the extension actually reads them.

…base

The extension uses its own bundled schema dir via getSettings(), so
gschema overrides have no effect. Move the menu display settings
(icon, location, arrow) into the dconf distro database where the
extension actually reads them.
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. area/policy System policies and configuration kind/bug Something isn't working labels Apr 14, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the dconf configuration for the custom command menu extension in Bluefin, adding specific settings for menu options, the menu icon, and its location, while also disabling the menu arrow. I have no feedback to provide as there are no review comments to evaluate.

@dylanmtaylor dylanmtaylor force-pushed the fix/custom-command-menu-icon branch from bb62162 to 2958ebd Compare April 14, 2026 00:44
@castrojo castrojo merged commit 4e00ee0 into projectbluefin:main Apr 14, 2026
1 check passed
@dylanmtaylor dylanmtaylor deleted the fix/custom-command-menu-icon branch April 14, 2026 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/policy System policies and configuration kind/bug Something isn't working size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants