feat: add DX variant of ublue panel logo#270
feat: add DX variant of ublue panel logo#270dylanmtaylor wants to merge 1 commit intoprojectbluefin:mainfrom
Conversation
Adds ublue-logo-dx-symbolic.svg with a diagonal blue racing stripe behind the U shape, intended to visually indicate when DX mode is active. The stripe is clipped to the backing shape and the U remains a transparent cutout for proper theme compatibility.
There was a problem hiding this comment.
Code Review
This pull request introduces a new symbolic SVG icon for the ublue-logo-dx. The review feedback correctly identifies a potential rendering issue where the hardcoded hex color in the symbolic icon may be stripped or become invisible when the system theme applies its own colors. It is recommended to use 'currentColor' with 'fill-opacity' to ensure the design remains visible and compatible with symbolic icon standards.
| <g mask="url(#u-mask)"> | ||
| <path fill="currentColor" d="M296 296H120C53.7258 296 0 242.274 0 176V30C0 13.4315 13.4315 0 30 0H266C282.569 0 296 13.4315 296 30V296Z" /> | ||
| <g clip-path="url(#outer)"> | ||
| <rect x="170" y="-80" width="50" height="520" transform="rotate(40 180 130)" fill="#5BC0EB" /> |
There was a problem hiding this comment.
The hardcoded hex color #5BC0EB will likely be overridden when the icon is rendered in a symbolic context (e.g., in the GNOME Shell panel). Standard symbolic icon renderers strip specific colors and apply the theme's foreground color (currentColor) to the entire icon. Since the backing path also uses currentColor, the stripe will become invisible. To maintain a visual distinction while remaining compatible with symbolic icon recoloring, consider using fill-opacity to create a shaded effect.
<rect x="170" y="-80" width="50" height="520" transform="rotate(40 180 130)" fill="currentColor" fill-opacity="0.5" />
Adds
ublue-logo-dx-symbolic.svg: a variant of the panel logo with a diagonal blue racing stripe behind the U shape. Intended to visually indicate when DX mode is active.The idea came from a conversation with Jorge about having a subtle visual difference in the panel when DX is enabled, like a racing stripe or hood scoop. The stripe is rendered between the backing and the U cutout, so it peeks through like the turbo glowing underneath.
currentColorfor the backing + U cutout (works on light and dark panels)#5BC0EB) clipped to the outer shape