feat: replace LogoMenu with Custom Command Menu extension#264
feat: replace LogoMenu with Custom Command Menu extension#264castrojo merged 1 commit intoprojectbluefin:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request replaces the Logo-menu extension with custom-command-menu, introducing a new configuration and a custom symbolic icon. Feedback indicates that the new configuration lacks the DistroShelf entry and Containers submenu previously available, uses a menu setting that may display unintended text, and includes an SVG with hardcoded colors that prevent proper theme integration. Additionally, the MOTD tips require updates to reflect the new menu structure.
system_files/bluefin/etc/dconf/db/distro.d/04-bluefin-custom-command-menu
Outdated
Show resolved
Hide resolved
system_files/bluefin/usr/share/glib-2.0/schemas/zz0-bluefin-modifications.gschema.override
Show resolved
Hide resolved
system_files/bluefin/usr/share/icons/hicolor/scalable/actions/ublue-logo-symbolic.svg
Outdated
Show resolved
Hide resolved
dylanmtaylor
force-pushed
the
custom-command-menu
branch
4 times, most recently
from
6ff5478 to
860ecbe
Compare
dosubot
bot
added
size:M
dylanmtaylor
force-pushed
the
custom-command-menu
branch
2 times, most recently
from
718f096 to
605f8ec
Compare
|
The menu doesn't look like anything specced in the issue? We just need the one in the issue implemented. And we ship distroshelf not boxbuddy. |
|
We can punt on "Ask Bluefin" until latest though so we can leave that one out, thanks! |
dylanmtaylor
force-pushed
the
custom-command-menu
branch
from
605f8ec to
1c7d4b8
Compare
dosubot
bot
added
size:L
@castrojo Odd, my bluefin has boxbuddy instead of distroshelf. I pushed a version with your menu (incl. ask bluefin), and came up with a way to get the hostname in the menu using a oneshot service that starts on graphical session start. There's no way to evaluate within custom menu. |
|
dylanmtaylor
force-pushed
the
custom-command-menu
branch
2 times, most recently
from
5544b7e to
ffb53f1
Compare
|
+1 from me, thanks for making the adjustments, since this is a service I'll let the others comment. |
|
Let's see if we can get StorageB/custom-command-menu#10 upstreamed and then use that for the hostname setting |
|
Can we land the config now so we can ship custom menu in dakota? Since we're making good progress there we might as well ship it. |
I'm happy to land this now and pull out the systemd service and replace it with the new version in the future. |
dylanmtaylor
force-pushed
the
custom-command-menu
branch
from
ffb53f1 to
352550a
Compare
Replace logomenu@aryan_k with [email protected] for the panel menu. This extension supports translations, is actively maintained, and allows fully customizable command entries. Menu entries: Terminal, Files, System Monitor, Settings, Extension Manager, and Software (Bazaar) with the ublue 'u' icon in the panel. Note: The main bluefin image Containerfile will also need to be updated to install [email protected] instead of logomenu@aryan_k. Ref: projectbluefin#222
dylanmtaylor
force-pushed
the
custom-command-menu
branch
from
352550a to
bc8d372
Compare
Swaps logomenu for StorageB/custom-command-menu, which is actively maintained, supports translations, and is fully customizable. Mirrors projectbluefin/common#264. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
Swaps logomenu for StorageB/custom-command-menu, which is actively maintained, supports translations, and is fully customizable. Mirrors projectbluefin/common#264. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
3 participants
Replaces logomenu with Custom Command Menu. Supports translations, actively maintained, fully customizable entries.
The main bluefin image Containerfile will also need to swap the extension package.
Ref: #222