Implement true stack navigation by pushing/popping room or thread views#775
Merged
kevinaboos merged 3 commits intoproject-robius:mainfrom Mar 24, 2026
Merged
Conversation
This is mostly important for mobile view, in which a user might jump to a different thread or room from one room, and then wish to go back through the previous history of rooms in the order they were visited.
3 tasks
Currently hardcoded to a max of 16 independent view that can be pushed/popped off the stack. For more, and to do it properly, we need additional restructurings of the StackNavigation widget within Makepad itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is mostly important for mobile view, in which a user might jump to a different thread or room from one room, and then wish to go back through the previous history of rooms in the order they were visited.
Remove the unnecessary
StackNavigationWrapper, since we now don't use actions but rather call functions on theStackNavigationwidget directly.Addresses the first task in #760