Skip to content

Add verification options#115

Merged
Yatekii merged 1 commit intoprobe-rs:masterfrom
bugadani:verify
May 19, 2025
Merged

Add verification options#115
Yatekii merged 1 commit intoprobe-rs:masterfrom
bugadani:verify

Conversation

@bugadani
Copy link
Copy Markdown
Contributor

@bugadani bugadani commented Mar 7, 2025

@bugadani bugadani marked this pull request as ready for review May 19, 2025 17:56
@bugadani bugadani requested a review from Copilot May 19, 2025 17:57
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds two new flashing verification options to the extension’s configuration schema and bumps the package version.

  • Bumps extension version from 0.24.2 to 0.25.0
  • Introduces verifyBeforeFlashing and verifyAfterFlashing schema properties with defaults
  • Updates sample flashingConfig in package.json
Comments suppressed due to low confidence (2)

package.json:604

  • Add tests to cover the new verifyBeforeFlashing and verifyAfterFlashing settings in the flashing workflow to ensure they behave correctly under different configurations.
"verifyBeforeFlashing": true,

package.json:4

  • Don't forget to update CHANGELOG.md or release notes to document the version bump and the addition of these two new configuration options.
"version": "0.25.0",

Comment thread package.json
Comment thread package.json Outdated
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces verification options around flashing operations and bumps the extension version.

  • Bumps extension version from 0.24.2 to 0.25.0
  • Adds verifyBeforeFlashing and verifyAfterFlashing boolean settings with defaults
  • Updates sample configurations to enable both new verify flags by default
Comments suppressed due to low confidence (3)

package.json:4

  • The version was bumped to 0.25.0; ensure the CHANGELOG.md is updated to reflect these changes so users are aware of the new verify options.
"version": "0.25.0",

package.json:231

  • Update the README or user documentation to include details about the new verifyBeforeFlashing option, its behavior, and intended use cases.
"verifyBeforeFlashing": {

package.json:236

  • Update the README or user documentation to include details about the new verifyAfterFlashing option so users know when to enable it.
"verifyAfterFlashing": {

Comment thread package.json
Comment thread package.json
@bugadani bugadani requested a review from Yatekii May 19, 2025 18:04
@Yatekii Yatekii merged commit b4ee9bc into probe-rs:master May 19, 2025
3 checks passed
@bugadani bugadani deleted the verify branch May 19, 2025 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants