Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
Adds two new flashing verification options to the extension’s configuration schema and bumps the package version.
- Bumps extension version from 0.24.2 to 0.25.0
- Introduces
verifyBeforeFlashingandverifyAfterFlashingschema properties with defaults - Updates sample
flashingConfigin package.json
Comments suppressed due to low confidence (2)
package.json:604
- Add tests to cover the new
verifyBeforeFlashingandverifyAfterFlashingsettings in the flashing workflow to ensure they behave correctly under different configurations.
"verifyBeforeFlashing": true,
package.json:4
- Don't forget to update
CHANGELOG.mdor release notes to document the version bump and the addition of these two new configuration options.
"version": "0.25.0",
There was a problem hiding this comment.
Pull Request Overview
This PR introduces verification options around flashing operations and bumps the extension version.
- Bumps extension version from 0.24.2 to 0.25.0
- Adds
verifyBeforeFlashingandverifyAfterFlashingboolean settings with defaults - Updates sample configurations to enable both new verify flags by default
Comments suppressed due to low confidence (3)
package.json:4
- The version was bumped to 0.25.0; ensure the CHANGELOG.md is updated to reflect these changes so users are aware of the new verify options.
"version": "0.25.0",
package.json:231
- Update the README or user documentation to include details about the new
verifyBeforeFlashingoption, its behavior, and intended use cases.
"verifyBeforeFlashing": {
package.json:236
- Update the README or user documentation to include details about the new
verifyAfterFlashingoption so users know when to enable it.
"verifyAfterFlashing": {
Yatekii
approved these changes
May 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion PR