Skip to content

fix: fix NaN for input number when pressing meta+backspace #8410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
patrickschroeter wants to merge 2 commits into
base: master
Choose a base branch
from
+26 −1
Open

fix: fix NaN for input number when pressing meta+backspace #8410

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eca7a71
fix: fix NaN for input number when pressing meta+backspace
patrickschroeter Jan 30, 2026
e1b014f
fix: fix NaN for input number without allow-empty
patrickschroeter Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions packages/primevue/src/inputnumber/InputNumber.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,22 @@ describe('InputNumber.vue', () => {
expect(wrapper.find('input.p-inputnumber-input').element._value).toBe('$12,345.00');
});

it('should reset value to undefined when meta+backspace is pressed with allow-empty', async () => {
await wrapper.setProps({ modelValue: 20, mode: 'currency', currency: 'USD', allowEmpty: true });

await wrapper.vm.onInputKeyDown({ code: 'Backspace', metaKey: true, target: { value: 100 }, preventDefault: () => {} });

expect(wrapper.find('input.p-inputnumber-input').element._value).toBe(undefined);
});

it('should reset value to 0 when meta+backspace is pressed without allow-empty', async () => {
await wrapper.setProps({ modelValue: 20, mode: 'currency', currency: 'USD', allowEmpty: false });

await wrapper.vm.onInputKeyDown({ code: 'Backspace', metaKey: true, target: { value: 100 }, preventDefault: () => {} });

expect(wrapper.find('input.p-inputnumber-input').element._value).toBe('$0.00');
});

it('should have prefix', async () => {
await wrapper.setProps({ modelValue: 20, prefix: '%' });

Expand Down
11 changes: 10 additions & 1 deletion packages/primevue/src/inputnumber/InputNumber.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,7 +422,17 @@ export default {
return;
}

const code = event.code || event.key;

if (event.altKey || event.ctrlKey || event.metaKey) {
if (event.metaKey && code === 'Backspace') {
this.lastValue = this.allowEmpty ? null : '0';

this.updateModel(event, this.lastValue);

return;
}

this.isSpecialChar = true;
this.lastValue = this.$refs.input.$el.value;

Expand All @@ -436,7 +446,6 @@ export default {
let selectionRange = selectionEnd - selectionStart;
let inputValue = event.target.value;
let newValueStr = null;
const code = event.code || event.key;

switch (code) {
case 'ArrowUp':
Expand Down