Skip to content

Detect missing list #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
raphaelm wants to merge 1 commit into
base: master
Choose a base branch
from
+13 −1
Open

Detect missing list #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions libpretixsync/src/main/java/eu/pretix/libpretixsync/check/OnlineCheckProvider.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,16 @@ class OnlineCheckProvider(
res.type = TicketCheckProvider.CheckResult.Type.INVALID
} else {
val response = responseObj.data!!

if (responseObj.response.code == 400 && !response.has("status")) {
if (response.has("lists")) {
// Kind of a special case handling, but regular problem for users and just
// passing through the error messages from the server is not generally helpful
// since user's don't know what a primary key is etc
throw CheckException("Check-in list not found")
}
}

val status = response.getString("status")
if ("ok" == status) {
res.type = TicketCheckProvider.CheckResult.Type.VALID
Expand Down
4 changes: 3 additions & 1 deletion libpretixsync/src/main/java/eu/pretix/libpretixsync/check/ProxyCheckProvider.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,9 @@ class ProxyCheckProvider(private val config: ConfigStore, httpClientFactory: Htt
e.printStackTrace()
TicketCheckProvider.CheckResult(TicketCheckProvider.CheckResult.Type.ERROR, e.message)
} catch (e: CheckException) {
TicketCheckProvider.CheckResult(TicketCheckProvider.CheckResult.Type.ERROR, e.message)
val r = TicketCheckProvider.CheckResult(TicketCheckProvider.CheckResult.Type.ERROR, e.message)
r.reasonExplanation = e.message
r
}
}

Expand Down
Loading