Change Order.payments and Order.refunds properties to nullable#65
Draft
Change Order.payments and Order.refunds properties to nullable#65
Conversation
The corresponding JSON values are only synced conditionally and using fallback values of empty JSON arrays can lead to bugs and confusion. The new null value will allow us to check whether the values have been redacted during sync and log errors whenever we encounter this in an unexpected code path. See #59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #59.
The corresponding JSON values are only synced conditionally and using fallback values of empty JSON arrays can lead to bugs and confusion. The new null value will allow us to check whether the values have been redacted during sync and log errors whenever we encounter this in an unexpected code path.