Skip to content

fixes #1698 - Update PropertyValues Id type to string#1699

Draft
jbyt1 wants to merge 1 commit intopnp:devfrom
jbyt1:bugfix/PropertyValues-Id
Draft

fixes #1698 - Update PropertyValues Id type to string#1699
jbyt1 wants to merge 1 commit intopnp:devfrom
jbyt1:bugfix/PropertyValues-Id

Conversation

@jbyt1
Copy link

@jbyt1 jbyt1 commented Sep 29, 2025

fixes 1698 - Update PropertyValues Id type to string to avoid GUID parse exception when getting property bags containing ID field.

fixes 1698 - Update PropertyValues Id type to string to avoid GUID parse exception when getting property bags containing ID field.
@jbyt1 jbyt1 changed the title fixes 1698 - Update PropertyValues Id type to string fixes #1698 - Update PropertyValues Id type to string Sep 29, 2025
@jbyt1
Copy link
Author

jbyt1 commented Sep 29, 2025

This solves the parsing issue in #1698
But it doesn't guarantee the Id property in the PropertyValues model will be unique if the user has configured an Id file property which can be any value.

Is uniqueness for the model's key field a requirement?
If so, any suggestions on what the preferred fix would be for this?

@Adam-it Adam-it self-assigned this Mar 1, 2026
@Adam-it
Copy link
Member

Adam-it commented Mar 1, 2026

@jbyt1, thanks for looking into it and sorry for the late update.
I feel like this PR is more fixing the outcome with a workaround instead of addressing the conflict naming problem and as a result, we will lose type safety.
I will set this PR to draft for now and on the related issue lets first agree on the best fix for this problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Retrieving property bag results in FormatException when mapping json to model - Caused by custom ID property

2 participants