New command: spo folder archive. Closes #7181#7239
Open
Saurabh7019 wants to merge 3 commits intopnp:mainfrom
Open
New command: spo folder archive. Closes #7181#7239Saurabh7019 wants to merge 3 commits intopnp:mainfrom
Saurabh7019 wants to merge 3 commits intopnp:mainfrom
Conversation
Contributor
|
Thanks! We'll try to review it ASAP. |
Adam-it
requested changes
May 3, 2026
Member
Adam-it
left a comment
There was a problem hiding this comment.
@Saurabh7019 solid work and I only noticed one thing to correct, but I have a few things we need to recheck before we proceed:
- If we execute this command on the library root level, we get a quite confusing error message, which does not help the user. If archiving on the root level of the document library is not possible, it would be best if we handle and catch this case and present a valuable error message to the user
- I tested it locally, but I am not sure how to check if the folder is indeed archived 😁. I tried retrieving properties for that folder or any documents in that folder, and unfortunately non of them had any archived flag set. How did you test this command?
Contributor
Author
This is fixed.
You are right.. folder properties don't have an archival status. I tested it was by manually navigating to the folder in the UI and verifying that all files within the folder were archived. also, the archival can take some time to complete, so the status won't always be reflected immediately after the command runs. Let me know if you want me to include the below response for command execution, I chose not include it to keep it aligned with file-archive command. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7181