Updates CLI API usage docs. Closes #5699#7231
Updates CLI API usage docs. Closes #5699#7231officialasishkumar wants to merge 2 commits intopnp:mainfrom
Conversation
|
Hi @officialasishkumar, can you please first claim the issue before working on it? |
|
Commented on #5699 now for tracking. |
Adam-it
left a comment
There was a problem hiding this comment.
@officialasishkumar In general, the change is in the right direction, but let's refactor it to be a bit clearer before we merge.
| ```sh | ||
| node index.js | ||
| ``` | ||
|
|
There was a problem hiding this comment.
In general, this is what was described in the related issue, but what I think @martinlingstuyl intention was to simply extend the ## Integrate CLI for Microsoft 365 in your app section below with an additional few sentences that would explain that CLI for Microsoft 365 is an ES module and an app that will use it should be ES Module as well. It should also explain to use npm install @pnp/cli-microsoft365 to add the package. Let's also not imply ..."latest", I think mentioning how to install it will be enough, using latest in package.json for any npm package is generally not a safe approach as you may easily end up with a breaking change on the next npm install, so we should rather not recomment this in our docs
There was a problem hiding this comment.
Updated in 58a6dbb: moved the ES module and install guidance into the existing integration section and removed the package.json/latest example.
2d77b3f to
58a6dbb
Compare
Closes #5699
Summary
spo web getAPI example to use theurloption.Validation