Skip to content

Adds Docker build check to PR workflow. Closes #5033 #7230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
officialasishkumar wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −3
Open

Adds Docker build check to PR workflow. Closes #5033 #7230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion .github/workflows/check_pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,4 +157,16 @@ jobs:

- name: Build docs
run: npm run build
working-directory: docs
working-directory: docs
docker_build:
if: github.repository_owner == 'pnp'
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v6
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v4
- name: Build Docker image
uses: docker/build-push-action@v7
with:
push: false
4 changes: 2 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ ENV 0="/bin/bash" \

RUN bash -c 'echo "export PATH=$PATH:/home/cli-microsoft365/.npm-global/bin:/home/.local/bin" >> ~/.bash_profile' \
&& bash -c 'echo "export CLIMICROSOFT365_ENV=\"docker\"" >> ~/.bash_profile' \
&& bash -c 'npm i -g @pnp/cli-microsoft365@${CLI_VERSION} --omit=dev --quiet --no-progress' \
&& bash -c 'npm i -g @pnp/cli-microsoft365@${CLI_VERSION} --omit=dev --quiet --no-progress' \
&& bash -c 'echo "source /etc/bash/bash_completion.sh" >> ~/.bash_profile' \
&& bash -c 'echo "alias \"m365?\"=\"m365_chili\"" >> ~/.bash_profile' \
&& bash -c 'echo ". .bashrc" >> ~/.bash_profile' \
Expand All @@ -47,4 +47,4 @@ RUN bash -c 'echo "export PATH=$PATH:/home/cli-microsoft365/.npm-global/bin:/hom
&& pwsh -c 'm365 cli completion pwsh setup --profile $profile' \
&& pwsh -c 'Add-Content -Path $PROFILE -Value "`r`Set-Alias -Name m365? -Value m365_chili"'

CMD [ "bash", "-l" ]
CMD [ "bash", "-l" ]
Loading