Skip to content

Updates node version handling in ci cd commands. Closes #6242#6696

Closed
Adam-it wants to merge 2 commits intopnp:mainfrom
Adam-it:fixex-ci-cd-scaffold-commands
Closed

Updates node version handling in ci cd commands. Closes #6242#6696
Adam-it wants to merge 2 commits intopnp:mainfrom
Adam-it:fixex-ci-cd-scaffold-commands

Conversation

@Adam-it
Copy link
Copy Markdown
Member

@Adam-it Adam-it commented Apr 18, 2025

Closes #6242

Result

image

image

Comment thread src/m365/spfx/commands/project/DeployWorkflow.ts
@Adam-it
Copy link
Copy Markdown
Member Author

Adam-it commented Apr 18, 2025

for now I wll change it to draft and when SPFx 1.21 will be GA we may reopen and merge this change

@Adam-it Adam-it marked this pull request as draft April 18, 2025 22:51
@Adam-it Adam-it marked this pull request as ready for review April 23, 2025 20:01
@Adam-it
Copy link
Copy Markdown
Member Author

Adam-it commented Apr 23, 2025

for now I wll change it to draft and when SPFx 1.21 will be GA we may reopen and merge this change

since it's out we may get this shipped

@Adam-it Adam-it self-assigned this Apr 25, 2025
Copy link
Copy Markdown
Member Author

@Adam-it Adam-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small thing to fixup

Comment thread src/m365/spfx/commands/project/project-azuredevops-pipeline-add.ts
@Adam-it
Copy link
Copy Markdown
Member Author

Adam-it commented Apr 25, 2025

Ready to merge 🚀

@Adam-it
Copy link
Copy Markdown
Member Author

Adam-it commented Apr 25, 2025

Merged manually 👏

@Adam-it Adam-it closed this Apr 25, 2025
@Adam-it Adam-it deleted the fixex-ci-cd-scaffold-commands branch April 25, 2025 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

We should remove the possibility to generate pipeline/workflow with node 16.x

1 participant