Adds command 'spe container recyclebinitem list'#6691
Closed
milanholemans wants to merge 1 commit intopnp:mainfrom
Closed
Adds command 'spe container recyclebinitem list'#6691milanholemans wants to merge 1 commit intopnp:mainfrom
milanholemans wants to merge 1 commit intopnp:mainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request refactors the way container type information is retrieved and processed by replacing functions in the spo module with improved versions in the spe module while adding a new command that lists deleted containers (recycle bin items) for a given container type.
- Removed the legacy getAllContainerTypes implementation from the spo module and updated tests accordingly.
- Introduced new spe module functions (getAllContainerTypes and getContainerTypeIdByName) and updated related containertype commands and tests.
- Added a new command (container recyclebinitem list) along with its corresponding tests and documentation sidebar updates.
Reviewed Changes
Copilot reviewed 16 out of 17 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/utils/spo.ts | Removed ContainerTypeProperties interface and getAllContainerTypes, as functionality has moved to spe.ts. |
| src/utils/spo.spec.ts | Removed tests for getAllContainerTypes, maintaining focus on the new implementation. |
| src/utils/spe.ts | Added new functions to retrieve and process container type data, including GUID extraction. |
| src/utils/spe.spec.ts | Added tests to validate the new spe module functions. |
| src/utils/formatting.ts / formatting.spec.ts | Introduced and tested a helper function to extract GUIDs from CSOM-formatted strings. |
| src/m365/spe/commands/containertype/* | Updated containertype list and get commands to use the new spe module functions. |
| src/m365/spe/commands/container/* | Added a new command for listing container recycle bin items and updated container list command to use spe. |
| src/m365/spe/commands.ts | Registered the new container recyclebinitem list command. |
| docs/src/config/sidebars.ts | Updated sidebar configuration to include documentation on the new command. |
Files not reviewed (1)
- docs/docs/cmd/spe/container/container-recyclebinitem-list.mdx: Language not supported
milanholemans
force-pushed
the
spe-container-recycle-list
branch
from
0e2c0e6 to
4fbe863
Compare
martinlingstuyl
approved these changes
May 22, 2025
Contributor
martinlingstuyl
left a comment
martinlingstuyl
left a comment
There was a problem hiding this comment.
Great work Milan! I'll fix the one comment while merging
Contributor
|
Merged manually, thanks!! ⚡ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6156
Additionally, I've created an
speutil to centralize shared code. I've also updated all existing commands that could benefit from this util.