Skip to content

Adds 'spe containertype remove' command#6674

Closed
milanholemans wants to merge 1 commit intopnp:mainfrom
milanholemans:spe-container-remove
Closed

Adds 'spe containertype remove' command#6674
milanholemans wants to merge 1 commit intopnp:mainfrom
milanholemans:spe-container-remove

Conversation

@milanholemans
Copy link
Copy Markdown
Contributor

Closes #5992


Made some small additional enhancement to the already existing commands.

@milanholemans milanholemans requested a review from Copilot April 4, 2025 21:57
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 10 out of 14 changed files in this pull request and generated 1 comment.

Files not reviewed (4)
  • docs/docs/cmd/spe/containertype/containertype-add.mdx: Language not supported
  • docs/docs/cmd/spe/containertype/containertype-get.mdx: Language not supported
  • docs/docs/cmd/spe/containertype/containertype-list.mdx: Language not supported
  • docs/docs/cmd/spe/containertype/containertype-remove.mdx: Language not supported

Comment thread src/m365/spe/commands/containertype/containertype-remove.ts Outdated
@milanholemans milanholemans force-pushed the spe-container-remove branch from 29d2adb to 19788da Compare April 4, 2025 21:58
@milanholemans milanholemans requested a review from Copilot April 4, 2025 21:59
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 10 out of 14 changed files in this pull request and generated no comments.

Files not reviewed (4)
  • docs/docs/cmd/spe/containertype/containertype-add.mdx: Language not supported
  • docs/docs/cmd/spe/containertype/containertype-get.mdx: Language not supported
  • docs/docs/cmd/spe/containertype/containertype-list.mdx: Language not supported
  • docs/docs/cmd/spe/containertype/containertype-remove.mdx: Language not supported

@milanholemans milanholemans force-pushed the spe-container-remove branch 2 times, most recently from 8783bfa to 4e9519f Compare April 4, 2025 22:04
@Adam-it
Copy link
Copy Markdown
Member

Adam-it commented Apr 6, 2025

Awesome work and enhancements done along the way 👍.
Thank you for taking up this 🚀

@milanholemans milanholemans marked this pull request as draft April 18, 2025 09:59
@milanholemans milanholemans marked this pull request as ready for review April 18, 2025 11:31
@martinlingstuyl martinlingstuyl self-assigned this May 22, 2025
Copy link
Copy Markdown
Contributor

@martinlingstuyl martinlingstuyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely! No comments...

@martinlingstuyl
Copy link
Copy Markdown
Contributor

Merged manually, thanks!! ⚡

@milanholemans milanholemans deleted the spe-container-remove branch May 22, 2025 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New command: m365 spe containertype remove

4 participants