Memoize ref function#28
Open
elv1n wants to merge 2 commits intopmndrs:masterfrom
elv1n:fix-ref-function
Open
Conversation
added 2 commits
December 5, 2020 10:30
elv1n
commented
Dec 5, 2020
| webpack: { | ||
| mode: 'development', | ||
| devtool: 'inline-source-map', | ||
| node: { |
Author
There was a problem hiding this comment.
Tests fail with module fs and module not defined error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using measure and passing it as a ref to a child memo component causing rerendering.
Changes will help to prevent unnecessary rerendering and moving addListeneres and removeLlisteners out of a hook scope can be a light improvement