Skip to content

Feature/gitlab pipeline#11

Merged
pme123 merged 4 commits intodevelopfrom
feature/gitlab-pipeline
Apr 6, 2026
Merged

Feature/gitlab pipeline#11
pme123 merged 4 commits intodevelopfrom
feature/gitlab-pipeline

Conversation

@pme123
Copy link
Copy Markdown
Owner

@pme123 pme123 commented Apr 6, 2026

No description provided.

@pme123 pme123 merged commit f8eab66 into develop Apr 6, 2026
2 checks passed
@augmentcode
Copy link
Copy Markdown

augmentcode Bot commented Apr 6, 2026

🤖 Augment PR Summary

Summary: Adds optional GitLab CI pipeline generation to the helper update tooling.

Changes:

  • Extend DevConfig with an optional pipelineConfig and add a new PipelineConfig model
  • Update GenericFileGenerator to generate .gitlab-ci.yml (with GitLab security templates + a worker-test job) when configured
  • Bump Scala from 3.8.1 to 3.8.2

Technical Notes: The generated pipeline bootstraps tooling via Coursier and runs sbt "domain/test; worker/test".

🤖 Was this summary useful? React with 👍 or 👎

Copy link
Copy Markdown

@augmentcode augmentcode Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 2 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

| HTTP_PROXY: $$ALL_PROXY
| HTTPS_PROXY: $$ALL_PROXY
| SCALA_IMAGE: ${pipelineConfig.baseImage}
| ${pipelineConfig.companyMVNUser}: $$CI_REGISTRY_USER
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pipelineConfig.companyMVNUser / companyMVNPassword are interpolated as YAML variable keys; given the names, it’s easy for callers to accidentally pass actual credentials and end up writing them into .gitlab-ci.yml (or generating invalid YAML). Consider ensuring these values are clearly/strictly treated as env-var names (validated/sanitized) before generating the file.

Severity: medium

Other Locations
  • 04-helper/src/main/scala/orchescala/helper/util/PipelineConfig.scala:7
  • 04-helper/src/main/scala/orchescala/helper/util/PipelineConfig.scala:8

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

| variables:
| CI_DEBUG_SERVICES: false
| script:
| - echo $$CI_REGISTRY_USER
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This echo $$CI_REGISTRY_USER will print the registry username into CI logs; consider whether that’s intended for all pipelines (especially if logs are shared externally).

Severity: low

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant