Draft
Conversation
…d build processes
…tion call, as the translations are loaded from translate.wordpress.org
We support >= 7, so the 5.4 stuff is obsolete. Remove it.
* remove "lint-all" which does not exist anymore * update WPCS to 3.0 * clean up GH action and update PHP version
Behat dependencies have been updated, but it is not expected that the tests will work. Add some simple rule tests to start with.
Types are now checked at function call, so we can assume the type is always correct at time of execution.
The script is currently checking if the `REQUEST_URI` is containing `wp-comments-post.php`, the default script to handle the submission of a comment. Some security plugins have options to rename this file to disguise that WordPress is used. With this fix, the `SCRIPT_NAME` is used instead. Since many security plugins do use rewrite rules, while the `REQUEST_URI` value is changed, the `SCRIPT_NAME` value stays the same. Therefor the condition would still recognize if a comment was submitted. Original fix by @2ndkauboy in #589, adapted to v3.
2ndkauboy
added a commit
that referenced
this pull request
Jul 27, 2025
The new code is using a `foreach` to get the two fields, but requires them to be in the correct order. This change uses a code similar to v2 which would get the parameters, independent of the order. Fixes: #506 (review)
We do not use this prefix and a new rule now fails because it is too short. Remove it from the configuration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.