Skip to content

Do not access location during import of tracker module #6039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
toofishes wants to merge 2 commits into
base: master
Choose a base branch
from
+7 −1
Open

Do not access location during import of tracker module #6039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
31185e9
Initialize currentEngagementURL to empty string, not location.href
toofishes Jan 30, 2026
95aae20
Set `exports` in plausible tracker package.json
toofishes Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions tracker/npm_package/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,12 @@
"license": "MIT",
"homepage": "https://plausible.io",
"type": "module",
"exports": {
".": {
"import": "./plausible.js",
"types": "./plausible.d.ts"
}
},
"module": "./plausible.js",
"types": "./plausible.d.ts"
}
2 changes: 1 addition & 1 deletion tracker/src/engagement.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { sendRequest } from './networking'
var listeningOnEngagement = false

var currentEngagementIgnored
var currentEngagementURL = location.href
var currentEngagementURL = ''
var currentEngagementProps = {}
var currentEngagementMaxScrollDepth = -1

Expand Down