Open
Conversation
threepointone
added a commit
to partykit/partykit
that referenced
this pull request
Jan 8, 2023
This forks `reconnecting-websocket` into our own package, and adds some functionality from abandoned PRs on the source repo. Of note: - pladaria/reconnecting-websocket#166 Fix: handle error if getNextUrl throws - pladaria/reconnecting-websocket#132 feat: make protocols updatable - pladaria/reconnecting-websocket#141 [Fix] Socket doesn't connect again after closing while connecting (TODO: more) - pladaria/reconnecting-websocket#163 Support for Dynamic Protocols - pladaria/reconnecting-websocket#47 reconnecting and reconnectscheduled custom events
threepointone
added a commit
to partykit/partykit
that referenced
this pull request
Jan 8, 2023
This forks `reconnecting-websocket` into our own package, and adds some functionality from abandoned PRs on the source repo. Of note: - pladaria/reconnecting-websocket#166 Fix: handle error if getNextUrl throws - pladaria/reconnecting-websocket#132 feat: make protocols updatable - pladaria/reconnecting-websocket#141 [Fix] Socket doesn't connect again after closing while connecting (TODO: more) - pladaria/reconnecting-websocket#163 Support for Dynamic Protocols - pladaria/reconnecting-websocket#47 reconnecting and reconnectscheduled custom events
This was referenced Apr 22, 2025
|
@maxfortun, hi, could you pls sign CLI on opensumi#11 ? |
Author
|
@diliks, sorry, that whole workflow looks very sus to me. Feel free to copy paste my changes and take ownership if you like. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue [#162].
Feature:
Dynamically provide Protocols on reconnect.
Use case:
Protocols is the only mechanism available to WebSocket to pass initialization information to the backend at connection time. As such, this could be leveraged for authorization. Modern authorization mechanisms, such as tokens, rotate over time and reconnecting with an old token will eventually fail. A dynamic Protocols provider can produce valid tokens at reconnect time.