Skip to content

Conversation

@vidarc
Copy link
Contributor

@vidarc vidarc commented Oct 16, 2025

re: #104

not at all used to programming in this language, but this fixed my issue and the other tests still passed. happy to make any other changes if this is not the best way to do this

@vidarc
Copy link
Contributor Author

vidarc commented Oct 20, 2025

@jasnell thoughts? If you have time

@vidarc
Copy link
Contributor Author

vidarc commented Oct 21, 2025

@metcoder95

@vidarc
Copy link
Contributor Author

vidarc commented Oct 21, 2025

maybe I'm missing something, but when running npm run build and npm run test locally, it will generate a file with the name @piscina+locks.node instead of what is currently in the prebuilds folder (node.napi.node). looks like it defaults to using the node.napi.node (or prefers it) instead of the one that is built locally for me. so the pipeline wasn't actually using my code changes from what i'm guessing.

@metcoder95
Copy link
Member

You are right, it will prefer always the ones build within prebuilts; that part hasn't been automated yet, but definitely would be nice to not need to pre-built it and rather just let the CI do the job.

Copy link
Member

@metcoder95 metcoder95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you bring back the prebuilds or couldn't produce them locally?

It seems you were having different output on these files

@vidarc
Copy link
Contributor Author

vidarc commented Oct 22, 2025

I can only produce the MacOS one locally. I don't have access to the other machines to produce those.

@vidarc
Copy link
Contributor Author

vidarc commented Oct 22, 2025

@metcoder95 ok, noticed that the pipeline uploads the built artifacts. downloaded those and added them to this PR. only prebuilt that I would be missing now is the darwin-x64 one, but i only have a M1 Mac, so can't build that myself.

@metcoder95
Copy link
Member

Perfect! Thanks, let me check them out and see if I can find a way to generate the x64 one

@vidarc
Copy link
Contributor Author

vidarc commented Oct 24, 2025

@metcoder95 https://github.com/actions/runner-images

added the macos-15-intel option to hopefully build out the missing prebuilt

@metcoder95
Copy link
Member

ok, I see what's happening; the change on the module naming cause builds to output another name. I'm opening a PR to address it

@metcoder95
Copy link
Member

Can you rebase with latest current?
New changes are there

@metcoder95
Copy link
Member

The binaries will be added upon every release

@metcoder95 metcoder95 merged commit 36314dd into piscinajs:current Nov 2, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants