-
Notifications
You must be signed in to change notification settings - Fork 4
fix: queue not processing as expected with multiple requests made #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@jasnell thoughts? If you have time |
|
maybe I'm missing something, but when running |
|
You are right, it will prefer always the ones build within |
metcoder95
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you bring back the prebuilds or couldn't produce them locally?
It seems you were having different output on these files
|
I can only produce the MacOS one locally. I don't have access to the other machines to produce those. |
|
@metcoder95 ok, noticed that the pipeline uploads the built artifacts. downloaded those and added them to this PR. only prebuilt that I would be missing now is the |
|
Perfect! Thanks, let me check them out and see if I can find a way to generate the x64 one |
|
@metcoder95 https://github.com/actions/runner-images added the |
|
ok, I see what's happening; the change on the module naming cause builds to output another name. I'm opening a PR to address it |
|
Can you rebase with latest |
|
The binaries will be added upon every release |
re: #104
not at all used to programming in this language, but this fixed my issue and the other tests still passed. happy to make any other changes if this is not the best way to do this