Add Ghostty terminal hyperlink support by the-spectator · Pull Request #3 · piotrmurach/tty-link

the-spectator · 2025-12-10T10:48:40Z

Closes #2

Describe the change

Add Ghostty terminal hyperlink support

Why are we doing this?

To extend the supported terminal list.

Requirements

piotrmurach

Hi Akshay,

Thank you for submitting this PR. 🙏

I'm all in favour of adding Ghostty support. I left a couple of comments, though. In particular, I'm curious about the version check. Would you have time to investigate?

CHANGELOG.md

lib/tty/link/terminals/ghostty.rb

spec/unit/terminals/ghostty_spec.rb

the-spectator · 2025-12-13T20:39:55Z

Thanks for the review @piotrmurach ! I have updated the code as per review comments.

piotrmurach

Thank you for making the changes. We are nearly there.

CHANGELOG.md

lib/tty/link/terminals/ghostty.rb

spec/unit/terminals/ghostty_spec.rb

the-spectator · 2026-01-12T14:01:34Z

Friendly bump for review.

piotrmurach

@the-spectator Sorry for the delay in my review.

I went through all the changes. Most comments relate to tests to ensure consistency in formatting and ordering. I included an extra test to match the other terminal tests.

Once this is merged, I plan to make a couple more changes to link rendering before making a new release.

piotrmurach · 2026-02-15T11:58:28Z

spec/unit/terminals/ghostty_spec.rb

@@ -0,0 +1,67 @@
+# frozen_string_literal: true
+
+RSpec.describe TTY::Link::Terminals::Ghostty, "#link?" do


Sorry for messing you around with this. I looked at other terminal tests. Let's keep the order consistent. So the naming and order should be:

"doesn't support links without the term program..."

"doesn't support links without a terminal program name"

"doesn't support links with a non-Ghostty program name"

"supports links above the 2.0.0 version" NEW test with 2.3.4 version.

"supports links above the 1.0.0 version"

"supports links on the 1.0.0 version"

"supports links on the 1.0.0 version with a mixed-case program name"

"doesn't support links below the 1.0.0 version"

"doesn't support links without a version"

"doesn't support links without the term program version env variable"

piotrmurach · 2026-02-15T11:59:12Z

spec/unit/terminals/ghostty_spec.rb

+  end
+
+  it "doesn't support links with a non-Ghostty program name" do
+    env = {"TERM_PROGRAM" => "other-terminal", "TERM_PROGRAM_VERSION" => "1.0.0"}


Suggested change

env = {"TERM_PROGRAM" => "other-terminal", "TERM_PROGRAM_VERSION" => "1.0.0"}

env = {"TERM_PROGRAM" => "other-terminal"}

piotrmurach · 2026-02-15T11:59:23Z

spec/unit/terminals/ghostty_spec.rb

+    expect(ghostty.link?).to eq(false)
+  end
+
+  it "supports links with the Ghostty program name" do


Suggested change

it "supports links with the Ghostty program name" do

it "supports links on the 1.0.0 version" do

piotrmurach · 2026-02-15T11:59:27Z

spec/unit/terminals/ghostty_spec.rb

+    expect(ghostty.link?).to eq(true)
+  end
+
+  it "supports links with the Ghostty program name in mixed case" do


Suggested change

it "supports links with the Ghostty program name in mixed case" do

it "supports links on the 1.0.0 version with a mixed-case program name" do

piotrmurach · 2026-02-15T11:59:30Z

spec/unit/terminals/ghostty_spec.rb

+    expect(ghostty.link?).to eq(true)
+  end
+
+  it "doesn't supports links without the term program version env variable" do


Suggested change

it "doesn't supports links without the term program version env variable" do

it "doesn't support links without the term program version env variable" do

piotrmurach · 2026-02-15T11:59:46Z

spec/unit/terminals/ghostty_spec.rb

+  end
+
+  it "doesn't supports links below version 1.0.0" do
+    env = env_with_name.merge({"TERM_PROGRAM_VERSION" => "0.9.0"})


Suggested change

env = env_with_name.merge({"TERM_PROGRAM_VERSION" => "0.9.0"})

env = env_with_name.merge({"TERM_PROGRAM_VERSION" => "0.9.2"})

piotrmurach · 2026-02-15T12:00:25Z

spec/unit/terminals/ghostty_spec.rb

+  end
+
+  it "supports links above the 1.0.0 version" do
+    env = env_with_name.merge({"TERM_PROGRAM_VERSION" => "1.1.0"})


Suggested change

env = env_with_name.merge({"TERM_PROGRAM_VERSION" => "1.1.0"})

env = env_with_name.merge({"TERM_PROGRAM_VERSION" => "1.0.1"})

piotrmurach · 2026-02-15T12:00:32Z

spec/unit/link_spec.rb


+    context "when Ghostty" do
+      it "supports links above the 1.0.0 version" do
+        env = {"TERM_PROGRAM" => "ghostty", "TERM_PROGRAM_VERSION" => "1.0.1"}


Suggested change

env = {"TERM_PROGRAM" => "ghostty", "TERM_PROGRAM_VERSION" => "1.0.1"}

env = {

"TERM_PROGRAM" => "ghostty",

"TERM_PROGRAM_VERSION" => "1.0.1"

}

piotrmurach · 2026-02-15T12:00:51Z

CHANGELOG.md

+* Add hyperlink support detection in Ghostty terminal
+  by Akshay Birajdar (@the-spectator).


Suggested change

* Add hyperlink support detection in Ghostty terminal

by Akshay Birajdar (@the-spectator).

* Add hyperlink support detection for the Ghostty terminal

by Akshay Birajdar (@the-spectator).

piotrmurach · 2026-02-15T12:01:04Z

lib/tty/link/terminals/ghostty.rb

+          !(term_program =~ GHOSTTY).nil?
+        end
+
+        # Detect any Ghostty terminal version to support terminal hyperlinks


This is no longer true. Let's change to:

Suggested change

# Detect any Ghostty terminal version to support terminal hyperlinks

# Detect whether the Ghostty version supports terminal hyperlinks

the-spectator · 2026-03-07T14:04:13Z

Thanks for the review @piotrmurach ! I have addressed the review comments.

piotrmurach reviewed Dec 10, 2025

View reviewed changes

the-spectator force-pushed the feat/ghostty branch from 33e1270 to 7778e6f Compare December 13, 2025 20:37

piotrmurach reviewed Dec 15, 2025

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

lib/tty/link/terminals/ghostty.rb Outdated Show resolved Hide resolved

spec/unit/terminals/ghostty_spec.rb Show resolved Hide resolved

spec/unit/terminals/ghostty_spec.rb Outdated Show resolved Hide resolved

the-spectator force-pushed the feat/ghostty branch 2 times, most recently from 5f9fbed to f7ab9bb Compare December 16, 2025 08:45

the-spectator requested a review from piotrmurach December 23, 2025 06:04

piotrmurach requested changes Feb 15, 2026

View reviewed changes

Add Ghostty terminal hyperlink support

5337e2f

the-spectator force-pushed the feat/ghostty branch from f7ab9bb to 5337e2f Compare March 7, 2026 14:03

Merge branch 'master' into feat/ghostty

65693f4

the-spectator requested a review from piotrmurach March 9, 2026 12:49

		@@ -0,0 +1,67 @@
		# frozen_string_literal: true

		RSpec.describe TTY::Link::Terminals::Ghostty, "#link?" do

	env = {"TERM_PROGRAM" => "other-terminal", "TERM_PROGRAM_VERSION" => "1.0.0"}
	env = {"TERM_PROGRAM" => "other-terminal"}

	it "supports links with the Ghostty program name" do
	it "supports links on the 1.0.0 version" do

	it "supports links with the Ghostty program name in mixed case" do
	it "supports links on the 1.0.0 version with a mixed-case program name" do

	it "doesn't supports links without the term program version env variable" do
	it "doesn't support links without the term program version env variable" do

	env = env_with_name.merge({"TERM_PROGRAM_VERSION" => "0.9.0"})
	env = env_with_name.merge({"TERM_PROGRAM_VERSION" => "0.9.2"})

		* Add hyperlink support detection in Ghostty terminal
		by Akshay Birajdar (@the-spectator).

	# Detect any Ghostty terminal version to support terminal hyperlinks
	# Detect whether the Ghostty version supports terminal hyperlinks

Uh oh!

Conversation

the-spectator commented Dec 10, 2025

Describe the change

Why are we doing this?

Requirements

Uh oh!

piotrmurach left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

the-spectator commented Dec 13, 2025

Uh oh!

piotrmurach left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

the-spectator commented Jan 12, 2026

Uh oh!

piotrmurach left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

the-spectator commented Mar 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants