ddl: add more corner tests for active-active | tidb-test=release-8.5-20260121-v8.5.5#66252
Conversation
1. show create view will hide internal columns now 2. ignore tidb_cdc db 3. forbid unique index on softdelete table 4. clone softdelete info Signed-off-by: xhe <xw897002528@gmail.com>
|
Hi @xhebox. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## release-8.5-20260121-v8.5.5 #66252 +/- ##
================================================================
Coverage ? 55.4329%
================================================================
Files ? 1820
Lines ? 653557
Branches ? 0
================================================================
Hits ? 362286
Misses ? 264373
Partials ? 26898
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
/hold |
D3Hunter
left a comment
There was a problem hiding this comment.
rest of non BR part lgtm
Signed-off-by: xhe <xw897002528@gmail.com>
[LGTM Timeline notifier]Timeline:
|
|
/retest |
1 similar comment
|
/retest |
|
/retest |
|
/retest |
1 similar comment
|
/retest |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: D3Hunter, Leavrth The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
1 similar comment
|
/retest |
|
/unhold |
c7e7cb7
into
pingcap:release-8.5-20260121-v8.5.5
What problem does this PR solve?
Issue Number: ref #64281
Problem Summary:
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.