Skip to content

ddl: add more corner tests for active-active | tidb-test=release-8.5-20260121-v8.5.5#66252

Merged
ti-chi-bot[bot] merged 8 commits intopingcap:release-8.5-20260121-v8.5.5from
xhebox:sg
Feb 14, 2026
Merged

ddl: add more corner tests for active-active | tidb-test=release-8.5-20260121-v8.5.5#66252
ti-chi-bot[bot] merged 8 commits intopingcap:release-8.5-20260121-v8.5.5from
xhebox:sg

Conversation

@xhebox
Copy link
Contributor

@xhebox xhebox commented Feb 13, 2026

What problem does this PR solve?

Issue Number: ref #64281
Problem Summary:

  1. show create view will hide internal columns now
  2. ignore tidb_cdc db
  3. forbid unique index on softdelete table
  4. clone softdelete info
  5. more tests

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

1. show create view will hide internal columns now
2. ignore tidb_cdc db
3. forbid unique index on softdelete table
4. clone softdelete info

Signed-off-by: xhe <xw897002528@gmail.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 13, 2026
@tiprow
Copy link

tiprow bot commented Feb 13, 2026

Hi @xhebox. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@xhebox
Copy link
Contributor Author

xhebox commented Feb 13, 2026

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Feb 13, 2026
@codecov
Copy link

codecov bot commented Feb 13, 2026

Codecov Report

❌ Patch coverage is 89.74359% with 4 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (release-8.5-20260121-v8.5.5@f5ceded). Learn more about missing BASE report.

Additional details and impacted files
@@                       Coverage Diff                        @@
##             release-8.5-20260121-v8.5.5     #66252   +/-   ##
================================================================
  Coverage                               ?   55.4329%           
================================================================
  Files                                  ?       1820           
  Lines                                  ?     653557           
  Branches                               ?          0           
================================================================
  Hits                                   ?     362286           
  Misses                                 ?     264373           
  Partials                               ?      26898           
Flag Coverage Δ
integration 39.2549% <79.4871%> (?)
unit 64.8133% <51.2820%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9278% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 63.8965% <0.0000%> (?)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: xhe <xw897002528@gmail.com>
lcwangchao
lcwangchao previously approved these changes Feb 13, 2026
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 13, 2026
@xhebox
Copy link
Contributor Author

xhebox commented Feb 13, 2026

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 13, 2026
Copy link
Contributor

@D3Hunter D3Hunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest of non BR part lgtm

Signed-off-by: xhe <xw897002528@gmail.com>
D3Hunter
D3Hunter previously approved these changes Feb 13, 2026
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 13, 2026
@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 13, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-02-13 10:14:41.492410836 +0000 UTC m=+4249.238804864: ☑️ agreed by lcwangchao.
  • 2026-02-13 10:43:23.182922642 +0000 UTC m=+5970.929316674: ☑️ agreed by D3Hunter.

@lcwangchao
Copy link
Collaborator

/retest

1 similar comment
@lcwangchao
Copy link
Collaborator

/retest

Signed-off-by: xhe <xw897002528@gmail.com>
@lcwangchao
Copy link
Collaborator

/retest

Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox
Copy link
Contributor Author

xhebox commented Feb 14, 2026

/retest

1 similar comment
@xhebox
Copy link
Contributor Author

xhebox commented Feb 14, 2026

/retest

@xhebox
Copy link
Contributor Author

xhebox commented Feb 14, 2026

/retest

@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 14, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, Leavrth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Feb 14, 2026
@lcwangchao
Copy link
Collaborator

/retest

1 similar comment
@lcwangchao
Copy link
Collaborator

/retest

@xhebox
Copy link
Contributor Author

xhebox commented Feb 14, 2026

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 14, 2026
@ti-chi-bot ti-chi-bot bot merged commit c7e7cb7 into pingcap:release-8.5-20260121-v8.5.5 Feb 14, 2026
24 of 48 checks passed
@lcwangchao lcwangchao deleted the sg branch February 14, 2026 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants