pkg/ddl, pkg/sessionctx: pass fulltext sysvars to TiCI | tidb-test=a9bf2dca824dc746361234cd4d763178e0eedd13 tiflash=feature-fts#65967
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## feature/fts #65967 +/- ##
===================================================
+ Coverage 72.3094% 72.4720% +0.1626%
===================================================
Files 1895 1922 +27
Lines 533272 535482 +2210
===================================================
+ Hits 385606 388075 +2469
+ Misses 123717 123272 -445
- Partials 23949 24135 +186
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
/retest |
1 similar comment
|
/retest |
|
/retest |
|
/retest |
1 similar comment
|
/retest |
| } | ||
|
|
||
| func (e *executor) captureFullTextIndexSysvarsToJob(sctx sessionctx.Context, job *model.Job, indexOption *ast.IndexOption) error { | ||
| parser := model.FullTextParserTypeStandardV1 |
There was a problem hiding this comment.
If we are to use the original parser type from the old full-text index, addtional checks and changes might be needed to check the parser type itself, as the old full-text has a wilder scope of support compared to the one we are implementing at the moment.
There was a problem hiding this comment.
Thanks for the heads-up. I did not change the parser-type compatibility logic in this PR; will follow up separately if/when we need to support carrying over legacy FULLTEXT parser settings.
|
/retest |
|
@JinheLin: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: JinheLin, OliverS929, winoros The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
/retest |
2 similar comments
|
/retest |
|
/retest |
What problem does this PR solve?
Issue Number: ref #63937
Problem Summary:
CREATE TABLE ... FULLTEXT INDEX ...).What changed and how does it work?
pkg/tici/tici.proto) to carryCreateIndexRequest.parser_infoandParserInfo.stop_words.parser_info.parser_paramsfrom job sysvars and (for standard parser + stopwords enabled + stopword table configured) reads stopwords from the table (single VARCHAR columnvalue) and sends the de-duplicated list viaparser_info.stop_words.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.