Avoid accumulating executed search debug traces outside debug mode#418
Open
simon-matt-oetztal wants to merge 1 commit into
Open
Avoid accumulating executed search debug traces outside debug mode#418simon-matt-oetztal wants to merge 1 commit into
simon-matt-oetztal wants to merge 1 commit into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Changes in this pull request
Resolves #417
Prevent SearchExecutionService debug trace accumulation outside debug mode
What
This PR changes
SearchExecutionServiceso that$executedSearchesis populated only when Pimcore debug mode is enabled.Why
SearchExecutionServicecurrently stores per-querySearchInformationincluding:debug_backtrace()In long-running CLI commands this accumulates and causes significant memory growth, although the data is only useful for debugging.
How
In
SearchExecutionService::executeSearch():$this->executedSearches[] = ...writes (success + exception path) in:if (Pimcore::inDebugMode()) { ... }Impact
Motivation / use case
This was observed during long-running data object update/import commands where memory rose steadily due to query trace collection.