Skip to content

Refine 2FA form#1090

Open
jdreesen wants to merge 3 commits intopimcore:2.3from
jdreesen:patch-1
Open

Refine 2FA form#1090
jdreesen wants to merge 3 commits intopimcore:2.3from
jdreesen:patch-1

Conversation

@jdreesen
Copy link
Contributor

@jdreesen jdreesen commented Feb 9, 2026

Currently, the browser's password manager always asks whether the 2FA code should be saved— however, this is never what you want, as it is a one-time code that changes every two minutes.

Therefore, we should change the type to text.
In addition, the input mode should be set to numeric so that the correct keyboard is displayed on mobile devices.

Copilot AI review requested due to automatic review settings February 9, 2026 11:27
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refines the admin 2FA verification form HTML attributes to reduce unwanted password-manager behavior and improve mobile input UX.

Changes:

  • Sets autocomplete="off" on the 2FA verification <form>.
  • Changes the 2FA code input from type="password" to type="text".
  • Adds inputmode="numeric" to encourage a numeric keyboard on mobile.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings February 9, 2026 11:31
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 9, 2026

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments