fix: Logical properties improve rtl support#599
Open
drmason13 wants to merge 5 commits intopicocss:mainfrom
Open
fix: Logical properties improve rtl support#599drmason13 wants to merge 5 commits intopicocss:mainfrom
drmason13 wants to merge 5 commits intopicocss:mainfrom
Conversation
|
Is this code review in progress? How can I help progress it? |
|
Would it make sense to also rename the Pico variables matching I'm using @drmason13's PR for a project, and in my mind, this additional change would complete the conversion from physical layout to logical layout. |
This was referenced Jan 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is similar to #560 by shuuji3 but it edits the scss files, runs the build to generate css and isn't limited to only left/right properties. It modifies top/bottom properties too.
I haven't tested I'm afraid, but I believe this will fix #591 (albeit, the button will still be on the "wrong" side, the order of HTML elements being reversed is intended behavior.)
First time contributing, so let me know if I can clean up the commits (probably wants squashing) to improve this.
And finally, thank you for this framework, it is very beautiful with good semantics.
FYI: this is a find/replace job if you want to do this yourself:
There's probably a postcss plugin for this now that I think about it. And yeah, the border-radius logical properties do look backwards but they're correct: https://developer.mozilla.org/en-US/docs/Web/CSS/border-end-start-radius