Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the extension’s zval cleanup calls to account for PHP 8.6 removing zval_dtor() (per PR description) by replacing it with zval_ptr_dtor_nogc() in worker/client/task code paths.
Changes:
- Replace
zval_dtor()withzval_ptr_dtor_nogc()inphp_gearman_worker.c. - Replace
zval_dtor()withzval_ptr_dtor_nogc()inphp_gearman_client.c. - Replace
zval_dtor()withzval_ptr_dtor_nogc()inphp_gearman_task.c.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| php_gearman_worker.c | Swap zval destructor calls in worker ctor/free/callback paths for PHP 8.6 compatibility. |
| php_gearman_task.c | Swap zval destructor calls in task object free handler. |
| php_gearman_client.c | Swap zval destructor calls in client object free handler and callback-reset paths. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zval_dtor() was removed in PHP 8.6 and is just an alias for zval_ptr_dtor_nogc()