Merged
Conversation
Member
|
Hi and thanks looking ok at first glance. I ll have a better look shortly. |
devnexen
reviewed
Feb 22, 2025
4662c06 to
06bee83
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to XML files within the documentation. The changes involve updating revision comments, modifying descriptions, and adding new sections for clarity. The most important changes are listed below:
Updates to Revision Comments and Descriptions:
IteratorAggregate::getIteratorto include that it returns an external iterator or a traversable object. (language/predefined/iteratoraggregate/getiterator.xml) [1] [2]Structural and Content Modifications:
appendices/resources.xmlto improve layout. (appendices/resources.xml)propertyhooktypein thereference/reflection/book.xmlfile. (reference/reflection/book.xml)Additional Notes and See Also Sections:
ReflectionProperty::isPublicto clarify that a public property is not always writable. (reference/reflection/reflectionproperty/ispublic.xml)seealsoreferences forReflectionProperty::isProtectedSetandReflectionProperty::isPrivateSet. (reference/reflection/reflectionproperty/ispublic.xml)