Skip to content

Update bc (c7e83fbbbcde9f54affc09424d032c38492a3ff4)#1992

Merged
devnexen merged 1 commit intophp:masterfrom
Fan2Shrek:upd/bc
Jan 14, 2025
Merged

Update bc (c7e83fbbbcde9f54affc09424d032c38492a3ff4)#1992
devnexen merged 1 commit intophp:masterfrom
Fan2Shrek:upd/bc

Conversation

@Fan2Shrek
Copy link
Contributor

No description provided.

@devnexen
Copy link
Member

can you rebase please ?

@devnexen
Copy link
Member

devnexen commented Jan 14, 2025

Oh I see there is legit pb with the previous commit, see for example

reference/bc/bcmath/number/divmod.xml 31:13

there is one too many <classname> tag

@devnexen
Copy link
Member

you can either create a separate PR to fix all of these or fixing here.

@Fan2Shrek
Copy link
Contributor Author

Should be fix,

Sorry for that 😅

Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@devnexen devnexen merged commit a60bc33 into php:master Jan 14, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants