Open
Conversation
Some requests do not allow sortFields so they need to made optional.
iranl
suggested changes
Jun 14, 2019
Contributor
iranl
left a comment
iranl
left a comment
There was a problem hiding this comment.
Seems like a sensible addition
src/BrowseDataRow.php
Outdated
| @@ -57,7 +57,7 @@ public function getCode(): string | |||
| * @param string $code | |||
Contributor
There was a problem hiding this comment.
@param string $code should be changed to @param string|null $code
src/BrowseDataRow.php
Outdated
| @@ -75,7 +75,7 @@ public function getNumber(): int | |||
| * @param int $number | |||
Contributor
There was a problem hiding this comment.
@param int $number should be changed to @param int|null $number
src/BrowseDataRow.php
Outdated
| @@ -93,7 +93,7 @@ public function getLine(): int | |||
| * @param int $line | |||
Contributor
There was a problem hiding this comment.
@param int $line should be changed to @param int|null $line
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using browse code 690 Twinfield will return an error when a sort fields are specified in the request. Without sort fields it works. The PHP Twinfield library currently requires sort fields. This change makes the sort fields optional.