Bug fix for ELU PyTorch implementation by multiplying with self.config["alpha"]#161
Open
MaungThantAI wants to merge 1 commit intophlippe:masterfrom
Open
Bug fix for ELU PyTorch implementation by multiplying with self.config["alpha"]#161MaungThantAI wants to merge 1 commit intophlippe:masterfrom
MaungThantAI wants to merge 1 commit intophlippe:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug description
In your original code of Tutorial: 3: Activation Functions (PyTorch), ELU is implemented as
I may be mistaken, but I believe there may be a small issue in Tutorial 3: Activation Functions (PyTorch), specifically in the implementation of the ELU activation function. In the current implementation, it appears that the output is not multiplied by self.config["alpha"]. I wondered whether this was intentional, perhaps assuming self.config["alpha"] = 1, or whether it might be an oversight. I hope that bringing this to your attention would be useful for you.
I fixed the implementation of ELU to