Guard against empty body in DOMDocument::loadHTML()#596
Merged
Conversation
Add an additional empty check after mb_convert_encoding() to prevent a ValueError when loadHTML() receives an empty string in PHP 8.1+. Fixes #332
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
empty()check aftermb_convert_encoding()inResponse::get_dom_document()to prevent aValueErrorwhenDOMDocument::loadHTML()receives an empty string on PHP 8.1+.! $bodycheck guards against empty input, butmb_convert_encoding()can return an empty string in edge cases (e.g., encoding detection failure), bypassing that guard.Fixes #332
Test plan
post_contentdoes not trigger aValueErrorfromDOMDocument::loadHTML()