Fix undefined constant error in WP handler#589
Merged
Conversation
Missing $ prefix on return variable caused PHP to interpret `response` as a constant, triggering a fatal error. Fixes #587
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes an error-handling bug in the WordPress API webmention handler so that WP_Error responses are correctly returned to the caller.
Changes:
- Correctly returns the
$responsevariable (instead of an undefinedresponse) whenRequest::get()returns aWP_Error.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$prefix onresponsevariable inincludes/handler/class-wp.php:73, which caused a PHP fatal error (Undefined constant "Webmention\Handler\response")Fixes #587