Fix PHP 8 TypeError in parse_post_json when JSON is invalid#566
Merged
Fix PHP 8 TypeError in parse_post_json when JSON is invalid#566
Conversation
Add is_array() check before accessing JSON data to prevent fatal error when json_decode returns null. Also use isset() for date and modified keys to prevent "undefined array key" warnings. Fixes #564
dshanske
approved these changes
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
is_array()check before accessing JSON data to prevent fatal error whenjson_decode()returns nullisset()fordateandmodifiedkeys to prevent "undefined array key" warnings in PHP 8+Fixes #564
Test plan