make user_rf_cal_sector_set a weak symbol so it can be overridden#234
Open
dfries wants to merge 1 commit intopfalcon:masterfrom
Open
make user_rf_cal_sector_set a weak symbol so it can be overridden#234dfries wants to merge 1 commit intopfalcon:masterfrom
dfries wants to merge 1 commit intopfalcon:masterfrom
Conversation
Owner
|
Why do you think it can't be overriden? How systems without weak symbols solved this issues for decades, before weak symbols appeared? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gives the user control of where the sector is allocated if they so choose or they get the default and don't have to think about it. I ran into a problem of not being able to compile esp-link because of the duplicate symbol (they defined it as well).