fix: allow verification sheet in private chat via sidebar navigation#1046
Open
malkovitc wants to merge 1 commit intopermissionlesstech:mainfrom
Open
fix: allow verification sheet in private chat via sidebar navigation#1046malkovitc wants to merge 1 commit intopermissionlesstech:mainfrom
malkovitc wants to merge 1 commit intopermissionlesstech:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #988 — Clicking on a person's name in a private chat did not open the security verification (fingerprint) sheet.
Root cause: SwiftUI does not allow multiple
.sheet()modifiers to be active simultaneously on the same view. When a private chat is open, the sidebar sheet is already presented, so the fingerprint sheet was silently ignored.Changes
1. Guard the root-level fingerprint sheet (line 195)
Added conditions to prevent the root-level fingerprint
.sheetfrom activating while the sidebar is open:2. Present fingerprint inside the sidebar via NavigationStack
Wrapped
peopleSheetViewcontent in aNavigationStackand added.navigationDestinationthat pushesFingerprintViewwhen the sidebar is active.Why navigation inside the sidebar instead of dismiss-then-present?
Test plan