PG-2116 Truncate query strings at multi-byte character boundaries#600
PG-2116 Truncate query strings at multi-byte character boundaries#600jeltz merged 1 commit intopercona:mainfrom
Conversation
|
The code looks good to me, but should all those test really fail? I see some of them succeed on other PRs |
Make sure we never create broken encodings in query strings by making the truncation of query strings multi-byte aware. An alternative would be to change the rule for truncation to be based on number of characters, as the documentation claims it is, but I do not think that would be significantly better. Either works just fine so we just pick one. Based on bug report from Ivan Vyazmitinov: percona#599
jeltz
force-pushed
the
query-mb-truncation
branch
from
ecfdf5d to
28e26ae
Compare
|
These PMM related tests fail in your PR too (#602). We should look into them but they are most likely cause by some change in PMM. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #600 +/- ##
==========================================
- Coverage 85.61% 85.49% -0.13%
==========================================
Files 3 3
Lines 1342 1344 +2
Branches 215 216 +1
==========================================
Hits 1149 1149
- Misses 91 92 +1
- Partials 102 103 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Yeah, but when I looked there was also some other workflows with failed status. seems to have worked now so probably flaky tests or something. |
Ah, then those likely disappeared when I rebased and pushed. |
3 participants
Make sure we never create broken encodings in query strings by making the truncation of query strings multi-byte aware. An alternative would be to change the rule for truncation to be based on number of characters, as the documentation claims it is, but I do not think that would be significantly better. Either works just fine so we just pick one.
Based on bug report from Ivan Vyazmitinov:
#599